Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail if there are no comments, labels or statuses. #1666

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Don't fail if there are no comments, labels or statuses. #1666

merged 1 commit into from
Dec 3, 2019

Conversation

bigkevmcd
Copy link
Member

@bigkevmcd bigkevmcd commented Dec 2, 2019 •
edited
Loading

Changes

This fixes #1665 by testing the error response from ioutil.ReadDir and not considering it to be an error if the directory does not exist.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

 - Can now update a pullrequest output, and add a status even if the PR has no comments.

@bigkevmcd
Handle error opening missing pull-request parts.
9565469 
When uploading a pullrequest resource, if there are no comments (or statuses,
or labels), then this is treated as a fatal error, and the upload
terminates.

This changes the behaviour to test the error, and not return the error if the
directory does not exist.
@tekton-robot tekton-robot requested review from a user and vdemeester December 2, 2019 22:19
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 2, 2019
@tekton-robot
Copy link
Collaborator

Hi @bigkevmcd. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2019
@bigkevmcd
Copy link
Member Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit and removed cla: no labels Dec 2, 2019
@ghost
Copy link

ghost commented Dec 2, 2019

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2019
@ghost
Copy link

ghost commented Dec 2, 2019

/lgtm

@tekton-robot tekton-robot assigned ghost Dec 2, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019
vdemeester
vdemeester approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @afrittoli

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@tekton-robot tekton-robot merged commit 780d9bd into tektoncd:master Dec 3, 2019
@afrittoli
Copy link
Member

I was a bit late in reviewing this, but thanks for this!

@bigkevmcd bigkevmcd deleted the dont-error-if-no-comments branch December 4, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PullRequest update fails if there are no comments (or labels or statuses)
5 participants
@bigkevmcd @googlebot @tekton-robot @afrittoli @vdemeester